Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebView: Support CSP Fix #12070

Merged
merged 1 commit into from
Jan 16, 2023
Merged

WebView: Support CSP Fix #12070

merged 1 commit into from
Jan 16, 2023

Conversation

FernandoAscencio
Copy link
Contributor

Implementation of the proposed fix for the CORS issue that did not allow images to be displayed in previews.

Sugned-off-by: FernandoAscencio [email protected]

What it does

Fix #11982 as proposed in the same article.

How to test

  1. Build and start the Theia Electron example from sources. Developing.md
  2. Install extension asciidoctor from extensions view open an asciidoc source file that references local images. E.g. "article.adoc" from repo [asciidoc-samples] https://github.com/opendevise/asciidoc-samples)
  3. Open the preview for the source file (click the corresponding button at the top right corner of editor)
  4. Confirm that images are shown in preview

Review checklist

Reminder for reviewers

@FernandoAscencio
WebView: Support CSP Fix
d25f5d7 
Implementation of the proposed fix for the CORS issue that did not allow
images to be displayed in previews.

Sugned-off-by: FernandoAscencio <[email protected]>
msujew
msujew approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

  • Webviews continue to work as expected
  • The Asciidoc extension shows images as expected

@msujew msujew added webviews issues related to webviews vscode issues related to VSCode compatibility labels Jan 16, 2023
@msujew msujew merged commit 056dca7 into eclipse-theia:master Jan 16, 2023
@FernandoAscencio FernandoAscencio deleted the fa/SupportCSPFix branch January 16, 2023 14:19
@marcdumais-work marcdumais-work mentioned this pull request Jan 16, 2023
Closed
@marcdumais-work
Copy link
Contributor

Thanks @FernandoAscencio and @msujew !

@paul-marechal paul-marechal added this to the 1.34.0 milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
vscode issues related to VSCode compatibility webviews issues related to webviews
Projects
None yet
Milestone
1.34.0
Development

Successfully merging this pull request may close these issues.

[WebViews] Support Content Security Policy that has "vscode-resource" entry
4 participants
@FernandoAscencio @marcdumais-work @msujew @paul-marechal